fix running indicator by ignoring PSRL aborts #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
commented
Nov 10, 2019
src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs
Show resolved
Hide resolved
rjmholt
approved these changes
Nov 11, 2019
SeeminglyScience
approved these changes
Nov 12, 2019
src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs
Outdated
Show resolved
Hide resolved
…erShellEditorServices into fix-running-indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2284
PSReadLine being cancelled was causing any operation that would show the running indicator to be immediately cancelled because a second message was being sent with
ExecutionStatus.Aborted.This ignores that one from PSRL.