Skip to content

Execution status indicator no longer appearing/working in status bar #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rjmholt opened this issue Nov 4, 2019 · 7 comments · Fixed by PowerShell/PowerShellEditorServices#1096
Labels

Comments

@rjmholt
Copy link
Contributor

rjmholt commented Nov 4, 2019

No description provided.

@rjmholt rjmholt changed the title SessionState indicator no longer appearing/working in status bar Execution status indicator no longer appearing/working in status bar Nov 4, 2019
@rjmholt
Copy link
Contributor Author

rjmholt commented Nov 4, 2019

Is it possible that the UI for this API has changed? I do see a blue indicator under the top left when I run things. My suspicion is that our API call still works, but that VSCode has changed the way they present it.

@rjmholt
Copy link
Contributor Author

rjmholt commented Nov 5, 2019

Link to @corbob's description: #2175 (comment)

@TylerLeonhardt
Copy link
Member

Yeah I can't see where the difference is. Stable it shows up, Preview it doesn't. Even though PSES hits the code path the same way.

@corbob
Copy link
Contributor

corbob commented Nov 8, 2019

FWIW: I'm getting the indicator when I run commands at the PSIC... just not if I run the commands from the editor window.

Easy demo:

in a ps1 file:

Start-Sleep -Seconds 15

Run with either F5 or F8

Copy the command and run it directly in PSIC.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Nov 8, 2019
@rjmholt
Copy link
Contributor Author

rjmholt commented Nov 8, 2019

Ah interesting. That's helpful. Thanks @corbob!

@TylerLeonhardt
Copy link
Member

I wonder if this is because we have to cancel the PSRL prompt in the F8 example and so the notification is getting fired but since there's a second executionStatus event that gets fired (where the state is Cancelled I think) theres a bit of a race condition.

@TylerLeonhardt
Copy link
Member

PR out for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants