-
Notifications
You must be signed in to change notification settings - Fork 235
The entire Debug Adapter moved over... #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
97e1357
2ce7dd8
52a5308
a6c1a0e
fc25e18
ced08a2
d000616
dea9d82
c0478c5
903f4fc
162f22c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"sdk": { | ||
"version": "2.1.602" | ||
"version": "2.1.801" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,7 +41,7 @@ function New-VSCodeHtmlContentView { | |
) | ||
|
||
process { | ||
if ($psEditor -is [Microsoft.PowerShell.EditorServices.Extensions.EditorObject]) { | ||
if ($psEditor -is [Microsoft.PowerShell.EditorServices.Engine.Services.PowerShellContext.EditorObject]) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like if we're keeping the extensions concept, it should be given a friendly namespace of its own that doesn't depend on the implementation detail of the PowerShellContext service. But not a huge thing for this PR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I agree. |
||
$viewFeature = $psEditor.Components.Get([Microsoft.PowerShell.EditorServices.VSCode.CustomViews.IHtmlContentViews]) | ||
$view = $viewFeature.CreateHtmlContentViewAsync($Title).Result | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the
@
s here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure but since this use to be a docfx website, there might be some special syntax with that.