The entire Debug Adapter moved over... #1043

TylerLeonhardt · 2019-09-25T04:51:01Z

This is a big PR... I know.

rjmholt · 2019-09-27T21:12:19Z

docs/api/index.md

@@ -20,9 +20,9 @@ the PowerShell debugger.
 Use the @Microsoft.PowerShell.EditorServices.Console.ConsoleService to provide interactive
 console support in the user's editor.

-Use the @Microsoft.PowerShell.EditorServices.Extensions.ExtensionService to allow
+Use the @Microsoft.PowerShell.EditorServices.Engine.Services.ExtensionService to allow


What are the @s here?

Not 100% sure but since this use to be a docfx website, there might be some special syntax with that.

rjmholt · 2019-09-27T21:14:24Z

module/PowerShellEditorServices.VSCode/Public/HtmlContentView/New-VSCodeHtmlContentView.ps1

@@ -41,7 +41,7 @@ function New-VSCodeHtmlContentView {
    )

    process {
-        if ($psEditor -is [Microsoft.PowerShell.EditorServices.Extensions.EditorObject]) {
+        if ($psEditor -is [Microsoft.PowerShell.EditorServices.Engine.Services.PowerShellContext.EditorObject]) {


I feel like if we're keeping the extensions concept, it should be given a friendly namespace of its own that doesn't depend on the implementation detail of the PowerShellContext service. But not a huge thing for this PR

Yeah I agree.

src/PowerShellEditorServices.Engine/Hosting/EditorServicesHost.cs

src/PowerShellEditorServices.Engine/Services/DebugAdapter/DebugEventHandlerService.cs

rjmholt · 2019-09-27T21:58:21Z

src/PowerShellEditorServices.Engine/Services/DebugAdapter/Debugging/VariableContainerDetails.cs

+        /// <summary>
+        /// Provides a constant for the name of the Global scope.
+        /// </summary>
+        public const string AutoVariablesName = "Auto";


Is this a thing?

I have seen "auto" in the variable pane of debugging. I'm not sure if that's something vscode defines that we are mirroring here or what.

Auto was our attempt to mirror what the Visual Studio debugger provides where it lists the variables it thinks are most relevant in the current debug context (stack frame). This worked better when the debugger was a traditional, non-REPL set up. But now that we execute scripts by dot sourcing them this feature is less useful because all script level variables wind up in the global scope along with dozens of other variables. We could make this work better in the dot source case by taking a "snapshot" of global variables when the session first starts, then Auto would show variables not in that original "global variables" snapshot and variables that are but whose values have changed.

When it works, it is a very useful feature.

Yeah thats sounds like the right direction to move in. I'll call it out of scope for this PR, but if you don't mind open a quick issue to capture this I'd appreciate it!

Done. #1045

rjmholt · 2019-09-27T22:36:04Z

test/PowerShellEditorServices.Test.E2E/TestsFixture.cs

@@ -70,6 +71,11 @@ public async Task InitializeAsync()
                "-Stdio"
            };

+            if (IsDebugAdapterTests)


If this is intended for a particular subclass, ideally the superclass shouldn't know about it at all. But in test classes, not such a big deal

yeah this isn't final. There's more work I need to do wrt testing.

Co-Authored-By: Robert Holt <[email protected]>

* initial non-working dap * working launch but not attach * working attach handler * update namespaces * Disconnect support and handling of JsonRpcServer teardown * Add foundation for debug tests - stdio and fixures * all handlers * remote file manager working * rest of debug adapter * use actual release * Apply suggestions from code review Co-Authored-By: Robert Holt <[email protected]>

* Add starting point * x * More work * Make integration tests pass for omnisharp * Changes * add dummy workspace symbols handler * use LoggerFactory * A working WorkspaceSymbolsHandler * working text document syncer * needed document selector and getVersion handler to work with vscode * Added Diagnostics * didChangeConfiguration message and general settings support * Add diagnostics (#18) * initial folding support * added test for folding * Add setting support (#19) * Added Diagnostics * didChangeConfiguration message and general settings support * Apply suggestions from code review Co-Authored-By: Robert Holt <[email protected]> * Folding support (#20) * Added Diagnostics * didChangeConfiguration message and general settings support * initial folding support * log level trace * folding works with latest omnisharp version * comment typo * added test for folding * formatting support * remove merge conflict * add formatting tests * DocumentSymbols and References support (#997) * working formatting * add tests * delete commented out code * [Omnisharp-LSP] textDocument/documentHighlight support (#999) * Add handler scaffold * More stuff * Make handler work * Add copyright * Add tests, fix bugs * Fix small issues * codelens support (#1001) * codelens support * address rob's feedback * powerShell/getPSHostProcesses and powerShell/getRunspace (#1002) * Test only pester for now (#1003) * Implement textDocument/codeAction (#1004) * Add initial handler * Add working codeAction implementation * Crash * Make tests work * Fix issues * Make tests work in WinPS * Add powershellcontext (#1005) * Add powershellcontext * using file sink now instead * all the newlines * support $psEditor (#1006) * support $psEditor * deleted commented out code * fix initial build failures due to lack of certain assemblies * use different RootPath * wait an extra 5 seconds just in case * refactor initialize script * Re-add Stdio option and replace Pester tests with xunit tests. (#1008) * Completion Support (#1007) * completion support * misc codacy fixes * use BUILD_ARTIFACTSTAGINGDIRECTORY so logs can be uploaded * publish artifacts even if build fails * handle log messages * give PSES a chance to run what it needs to run * switch to using xUnit output helper * treat DynamicKeywords as Keyword * completionresolve support (#1009) * handle log messages * switch to using xUnit output helper * Add completionItem/resolve request * feedback * update build to run update-help for signature help test * removing scope hoping it works in CI * setting to EA silentlycontinue * change to language=powershell * hover support (#1010) * handle log messages * switch to using xUnit output helper * add hover handler * move to language=powershell * refactoring for feedback * codacy * Omni signaturehelp (#1011) * handle log messages * switch to using xUnit output helper * Support SignatureHelp * concurrentdict * Add definition handler (#1013) * add definition handler * codacy * sneak in powerShell/executionStatusChanged * codacy * Add Plaster messages (#1014) * Comment Help and Evaluate (#1015) * Support for Comment Help generator * add evaluate handler * Last LSP messages (#1016) * support CommandExporer commands and powerShell/runspaceChanged * expand alias * refactor server setup (#1018) * rename namespaces (#1019) * The entire Debug Adapter moved over... (#1043) * initial non-working dap * working launch but not attach * working attach handler * update namespaces * Disconnect support and handling of JsonRpcServer teardown * Add foundation for debug tests - stdio and fixures * all handlers * remote file manager working * rest of debug adapter * use actual release * Apply suggestions from code review Co-Authored-By: Robert Holt <[email protected]> * Delete projects we wont be keeping around and get pses.vscode working again (#1046) * delete other folders and tweak build script for BuildInfo * working PowerShellEditorServices.VSCode now a binary module! * some typo * Apply suggestions from code review Co-Authored-By: Patrick Meinecke <[email protected]> * address additional comments * don't checkin maml * add error handling * deleted buildinfo and address rob's comments * Remove engine from files and namespaces (#1048) * apply apt state for PS7 (#1051) * delete buildinfo * implement powerShell/startDebugger (#1049) * implement powerShell/startDebugger * add line Co-Authored-By: Patrick Meinecke <[email protected]> * Enable alias corrections (#1053) * Codacy comments

TylerLeonhardt marked this pull request as ready for review September 25, 2019 04:51

TylerLeonhardt requested a review from rjmholt as a code owner September 25, 2019 04:51

TylerLeonhardt added 10 commits September 24, 2019 21:53

initial non-working dap

97e1357

working launch but not attach

2ce7dd8

working attach handler

52a5308

update namespaces

a6c1a0e

Disconnect support and handling of JsonRpcServer teardown

fc25e18

Add foundation for debug tests - stdio and fixures

ced08a2

all handlers

d000616

remote file manager working

dea9d82

rest of debug adapter

c0478c5

use actual release

903f4fc

TylerLeonhardt force-pushed the omni-debug-rest branch from a8b00f3 to 903f4fc Compare September 25, 2019 04:54

rjmholt approved these changes Sep 27, 2019

View reviewed changes

Apply suggestions from code review

162f22c

Co-Authored-By: Robert Holt <[email protected]>

TylerLeonhardt merged commit 456031c into PowerShell:omnisharp-lsp Sep 29, 2019

TylerLeonhardt deleted the omni-debug-rest branch September 29, 2019 17:37

rjmholt mentioned this pull request Oct 10, 2019

PowerShell session crashes when ANSI escape codes are used PowerShell/vscode-powershell#2176

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The entire Debug Adapter moved over... #1043

The entire Debug Adapter moved over... #1043

TylerLeonhardt commented Sep 25, 2019

rjmholt Sep 27, 2019

TylerLeonhardt Sep 28, 2019

rjmholt Sep 27, 2019

TylerLeonhardt Sep 28, 2019

rjmholt Sep 27, 2019

TylerLeonhardt Sep 28, 2019

rkeithhill Sep 28, 2019 •

edited

Loading

rkeithhill Sep 28, 2019

TylerLeonhardt Sep 29, 2019

rkeithhill Sep 29, 2019

rjmholt Sep 27, 2019

TylerLeonhardt Sep 28, 2019

The entire Debug Adapter moved over... #1043

The entire Debug Adapter moved over... #1043

Conversation

TylerLeonhardt commented Sep 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rkeithhill Sep 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rkeithhill Sep 28, 2019 •

edited

Loading