Fixed a bug where nullable enum like classes could not be deserialized correctly #564
Conversation
|
Thanks @david-driscoll! |
|
Fixes #562 |
| ( reader.TokenType, Nullable.GetUnderlyingType(objectType) ) switch { | ||
| (JsonToken.String, null) => (IEnumLikeString) Activator.CreateInstance(objectType, (string) reader.Value), | ||
| (JsonToken.String, { } realType) => (IEnumLikeString) Activator.CreateInstance(realType, (string) reader.Value), | ||
| _ => (IEnumLikeString) Activator.CreateInstance(objectType, null) |
There was a problem hiding this comment.
If we get something like PathFormat? (implying the value can be null), we could see a null from reader.Value I assume.
I would have expected the serialiser to return null in that circumstance rather than new PathFormat(null).
But also, if we do get a PathFormat?, we can't promise a non-nullable IEnumLikeString but rather I would have guessed we need to return IEnumLikeString?.
So in the realType branch, I would have expected something like:
reader.Value is null ? null : (IEnumLikeString) Activator.CreateInstance(realType, (string) reader.Value)
Does that make sense? Or is there something else going on here that makes that not a concern?
There was a problem hiding this comment.
that sounds correct, I'll update the pattern
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 73.40% 69.57% -3.83%
==========================================
Files 256 235 -21
Lines 12246 11809 -437
Branches 827 800 -27
==========================================
- Hits 8989 8216 -773
- Misses 3257 3377 +120
- Partials 0 216 +216
Continue to review full report at Codecov.
|
No description provided.