Support: Debug Adapter Protocol #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorkstromm
reviewed
Jul 20, 2019
david-driscoll
changed the title
|
@david-driscoll it looks like this PR has everything I need in order to use |
Misc dap fixes
remove extra Reciever
JsonRpcServer now disposable
switch null to new JObject so it can still be parsed into the right type
fix up WriteJson for DAP error handling
|
Alright, this feels done. Just need to get tests passing |
| /// Deprecated: The code locations of the breakpoints. | ||
| /// </summary> | ||
| [Obsolete("Deprecated")] | ||
| [Optional] public Container<long> Lines { get; set; } |
There was a problem hiding this comment.
@david-driscoll @TylerLeonhardt This seems to have been written deprecated...what should be used in place of it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TylerLeonhardt Just getting started on the DAP stuff... went pretty fast for the receiver end.
see: #145