Skip to content

fix up WriteJson for DAP error handling #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerLeonhardt
Copy link
Collaborator

Now in my handler I can do:

throw new RpcErrorException(0, "A positive integer must be specified for the processId field.");

and then I get:

image

One thing that does concern me is that the DAP spec says that command is required in Response bodies, but this functionality works as I want so I'm going to just ignore that detail for now as it might actually be optional.

@david-driscoll david-driscoll merged commit d3c0ae2 into OmniSharp:dap Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants