forked from NathanWalker/nativescript-plugin-seed
-
-
Notifications
You must be signed in to change notification settings - Fork 54
feat: make it possible for the user to choose what kind of demos (by framework) to be included and create them from online templates #128 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3e824c3
feat: use online templates to create demo applications
46af01f
chore
d24c88f
chore: add unit tests for the new postclone prompts
9973425
chore
d66ef41
chore: update readme with latest script changes
2210b63
chore: update travis with latest changes to postclone
9ec9c39
chore: remove scripts that are no longer static
fb4bdee
chore: Refactor success message to use variables
db9802a
chore: remove redundant npm install calls
978e646
chore: remove left over command symbols
533e169
chore: fix issues when running on cmd on Windows OS
084b3e3
chore: fix issues with running postclone on Windows OS
VladimirAmiorkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
43 changes: 0 additions & 43 deletions
43
demo/app/App_Resources/Android/src/main/AndroidManifest.xml
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-3.42 KB
demo/app/App_Resources/Android/src/main/res/drawable-hdpi/background.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-1.31 KB
demo/app/App_Resources/Android/src/main/res/drawable-ldpi/background.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-1.89 KB
demo/app/App_Resources/Android/src/main/res/drawable-mdpi/background.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
8 changes: 0 additions & 8 deletions
8
demo/app/App_Resources/Android/src/main/res/drawable-nodpi/splash_screen.xml
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-5.26 KB
demo/app/App_Resources/Android/src/main/res/drawable-xhdpi/background.png
Binary file not shown.
Binary file removed
BIN
-39.1 KB
demo/app/App_Resources/Android/src/main/res/drawable-xhdpi/icon.png
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-10.3 KB
demo/app/App_Resources/Android/src/main/res/drawable-xxhdpi/background.png
Binary file not shown.
Binary file removed
BIN
-41.2 KB
demo/app/App_Resources/Android/src/main/res/drawable-xxhdpi/icon.png
Binary file not shown.
Binary file removed
BIN
-116 KB
demo/app/App_Resources/Android/src/main/res/drawable-xxhdpi/logo.png
Binary file not shown.
Binary file removed
BIN
-3.87 KB
demo/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/background.png
Binary file not shown.
Binary file removed
BIN
-45.5 KB
demo/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/icon.png
Binary file not shown.
Binary file removed
BIN
-193 KB
demo/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/logo.png
Binary file not shown.
4 changes: 0 additions & 4 deletions
4
demo/app/App_Resources/Android/src/main/res/values-v21/colors.xml
This file was deleted.
Oops, something went wrong.
23 changes: 0 additions & 23 deletions
23
demo/app/App_Resources/Android/src/main/res/values-v21/styles.xml
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
demo/app/App_Resources/Android/src/main/res/values/colors.xml
This file was deleted.
Oops, something went wrong.
45 changes: 0 additions & 45 deletions
45
demo/app/App_Resources/Android/src/main/res/values/styles.xml
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still feel, that the
npm i
should be included in the scripts build/tsc instead of in the travis configurationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the postclone script has
npm i
in it so we do not need anything to have install since the first and only script that is required to be executed first isnpm run postclone
. I will remove this from the travis