feat: make it possible for the user to choose what kind of demos (by framework) to be included and create them from online templates #128 #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
VladimirAmiorkov
changed the title
VladimirAmiorkov
changed the title
feat: make it possible for the user to choose what kind of demos (by framework) to be included #128
VladimirAmiorkov
force-pushed
the
amiorkov/scripts-imrpvements
branch
from
3ce2e49 to
3e824c3
Compare
added 5 commits
May 12, 2019 18:27
chore: remove some unit tests as they are not needed
VladimirAmiorkov
changed the title
tgpetrov
reviewed
May 13, 2019
tgpetrov
reviewed
May 13, 2019
tgpetrov
approved these changes
May 13, 2019
elena-p
suggested changes
May 13, 2019
.travis.yml
Outdated
| @@ -16,7 +16,7 @@ matrix: | |||
| jdk: oraclejdk8 | |||
| before_install: nvm install 8 | |||
| script: | |||
| - cd src && npm i && npm run tsc && cd ../demo | |||
| - cd src && npm i && npm run tsc && npm run postclone gitHubUsername=TheGitHubUser pluginName=ThePlugin initGit=y includeTypescriptDemo=y includeAngularDemo=n && cd ../demo | |||
There was a problem hiding this comment.
I still feel, that the npm i should be included in the scripts build/tsc instead of in the travis configuration
There was a problem hiding this comment.
Actually the postclone script has npm i in it so we do not need anything to have install since the first and only script that is required to be executed first is npm run postclone. I will remove this from the travis
elena-p
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When the
postclonescript is executed updated the already present demo application in the seed.What is the new behavior?
When the
postclonescript is executed it will ask the user which framework type application he wants to be created in the repo and those applications will be created directly from thetns createcommand which uses the online templates.Fixes/Implements/Closes #[Issue Number].
#128
BREAKING CHANGES:
The demo application in the seed is deleted
The included "empty" unit test in the demo app is no longer present.
Migration:
As the unit tests are something that is changing over time it is best to manually follow the latest version of the https://docs.nativescript.org/tooling/testing/testing article and execute its commands to initialize unit tests structure in the apps.
There are no longer any included unit tests to the apps
Travis now only builds the app and does not run any unit tests