Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix: don't throw MaxListenersExceeded error when more than 11 processes are started from sidekick #695

Merged
merged 1 commit into from
Oct 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/after-watch.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
const { stopWebpackCompiler } = require('./compiler');
const { removeListener } = require("./utils");

module.exports = function($logger) {
module.exports = function($logger, $liveSyncService) {
$logger.info("Stopping webpack watch");
stopWebpackCompiler();
removeListener($liveSyncService, "liveSyncStopped");
removeListener(process, "exit");
}
8 changes: 3 additions & 5 deletions lib/before-watch.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
const { getWebpackProcesses, runWebpackCompiler, stopWebpackCompiler } = require("./compiler");
const { addListener } = require("./utils");

module.exports = function ($logger, $liveSyncService, $devicesService, hookArgs) {
if (hookArgs.config) {
const appFilesUpdaterOptions = hookArgs.config.appFilesUpdaterOptions;
if (appFilesUpdaterOptions.bundle) {
$liveSyncService.on("liveSyncStopped", data => {
addListener($liveSyncService, "liveSyncStopped", () => {
const webpackProcesses = getWebpackProcesses();
Object.keys(webpackProcesses).forEach(platform => {
const devices = $devicesService.getDevicesForPlatform(platform);
Expand All @@ -13,10 +14,7 @@ module.exports = function ($logger, $liveSyncService, $devicesService, hookArgs)
}
});
});

process.on("exit", () => {
stopWebpackCompiler();
});
addListener(process, "exit", stopWebpackCompiler);

const platforms = hookArgs.config.platforms;
return Promise.all(platforms.map(platform => {
Expand Down
20 changes: 19 additions & 1 deletion lib/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ const {
isAndroid,
} = require("../projectHelpers");

const eventHandlers = {};

function debuggingEnabled(liveSyncService, projectDir) {
const deviceDescriptors = liveSyncService.getLiveSyncDeviceDescriptors(projectDir);
return deviceDescriptors.some(device => device.debugggingEnabled);
Expand Down Expand Up @@ -76,10 +78,26 @@ function shouldSnapshot(config) {
return config.bundle && config.release && platformSupportsSnapshot && osSupportsSnapshot;
}

function addListener(eventEmitter, name, handler) {
if (!eventHandlers[name]) {
eventEmitter.on(name, handler);
eventHandlers[name] = handler;
}
}

function removeListener(eventEmitter, name) {
if (eventHandlers[name]) {
eventEmitter.removeListener(name, eventHandlers[name]);
delete eventHandlers[name];
}
}

module.exports = {
buildEnvData,
debuggingEnabled,
shouldSnapshot,
getUpdatedEmittedFiles,
parseHotUpdateChunkName
parseHotUpdateChunkName,
addListener,
removeListener
};