This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: don't throw MaxListenersExceeded error when more than 11 processes are started from sidekick #695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when the user runs 11 apps from sidekick (or only 2 apps changing them 6 times),
error is thrown. The problem occurs because we attach every time on
process.exit
andliveSyncStopped
events. So this PR fixes this behavior as ensures only one listener is added for each event.PR Checklist
What is the current behavior?
error is thrown when the user runs 11 apps from sidekick (or only 2 apps changing them 6 times)
What is the new behavior?
No error is thrown when the user runs 11 apps from sidekick (or only 2 apps changing them 6 times)