This repository was archived by the owner on Aug 7, 2021. It is now read-only.
refactor: loadChildren to work with ~/path and ./path both relative to app/ #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o app/ It turns out the ./path for loadChildren have never worked as relative to the routes module, and was always expected to be relative to app/ in non-webpack builds. Modifying the lazy loaded ninjas to feature both ./ and ~/ paths relative to the app.
sis0k0
approved these changes
Dec 12, 2017
MartoYankov
approved these changes
Dec 12, 2017
vchimev
pushed a commit
that referenced
this pull request
Dec 12, 2017
…lative to app/" (#349) * Revert "fix(update-ns-webpack): make it possible to call as executable (#347)" This reverts commit 9fa7656. * Revert "refactor: remove building through npm scripts (#336)" This reverts commit 6e63e3c. * Revert "chore: add update-ns-webpack to scripts (#346)" This reverts commit 8bd887b. * Revert "refactor: loadChildren to work with ~/path and ./path both relative to app/ (#338)" This reverts commit 49ef411.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the ./path for loadChildren have never worked as relative to the routes module,
and was always expected to be relative to app/ in non-webpack builds. Modifying the lazy loaded
ninjas to feature both ./ and ~/ paths relative to the app.