This repository was archived by the owner on Aug 7, 2021. It is now read-only.
refactor: remove building through npm scripts #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
sis0k0
suggested changes
Dec 11, 2017
There was a problem hiding this comment.
Can you add a BREAKING_CHANGES footer to the PR message about the npm scripts? Something like the following:
https://gist.github.com/stephenparish/9941e89d80e2bc58a153#message-footer
Also can you update the PR message to follow this convention: https://gist.github.com/stephenparish/9941e89d80e2bc58a153#subject-line? Something like the following should do it:
refactor: remove building through npm scripts
|
Ping @sis0k0 with renewed PR message and topic |
Mitko-Kerezov
changed the title
sis0k0
approved these changes
Dec 11, 2017
|
typescript-app-android |
Mitko-Kerezov
force-pushed
the
kerezov/docs-scripts
branch
from
1125ffc to
4168543
Compare
MartoYankov
reviewed
Dec 12, 2017
README.md
Outdated
| @@ -14,9 +14,9 @@ A package to help with webpacking NativeScript apps. | |||
| $ npm install --save-dev nativescript-dev-webpack | |||
| $ npm install | |||
There was a problem hiding this comment.
I believe this is no longer needed since tns run calls npm install.
Mitko-Kerezov
force-pushed
the
kerezov/docs-scripts
branch
from
6eaa7be to
34ce87c
Compare
vchimev
pushed a commit
that referenced
this pull request
Dec 12, 2017
…lative to app/" (#349) * Revert "fix(update-ns-webpack): make it possible to call as executable (#347)" This reverts commit 9fa7656. * Revert "refactor: remove building through npm scripts (#336)" This reverts commit 6e63e3c. * Revert "chore: add update-ns-webpack to scripts (#346)" This reverts commit 8bd887b. * Revert "refactor: loadChildren to work with ~/path and ./path both relative to app/ (#338)" This reverts commit 49ef411.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Part of NativeScript/NativeScript#5129
Ping @PanayotCankov @sis0k0
Breaking Changes
Executing
npm runscripts is no longer supported. The scripts will print an error message and exit with error code 1.