Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

chore: merge release in master #1031

Merged
merged 16 commits into from
Aug 20, 2019
Merged

Conversation

rosen-vladimirov
Copy link
Contributor

merge release in master

miroslavaivanova and others added 16 commits August 5, 2019 13:50
Currently the check for hot update creates a new file in case it does not exist (as the method from tns-core-modules is doing this). This is a problem when trying to install `.ipa` on device and the `.ipa` file contains JavaScript files with HMR enabled.
This may happen in case you run `tns run ios` on device and after command finishes the execution open the project in Xcode and deploy the app from there or uninstall it from device and install the produced `.ipa` manually. The problem in the mentioned scenarios is that the JavaScript file cannot write files in the directory where the `.ipa` is installed.
When `tns run ios` is executed, it livesyncs the files in a different location, so the HMR can create the files there.

To fix the issue check if the hmr file exist before reading its content.
Add ia64 as supported architecture and map it to x86_64 Android arch.
Older runtimes cannot work with ia64 arch (they do not have the x86_64 arch), so check the runtime version and remove the ia64 (and all new archs that we may add in the future).
fix: add ia64 as supported architecture
@cla-bot cla-bot bot added the cla: yes label Aug 20, 2019
@rosen-vladimirov
Copy link
Contributor Author

Failures are not caused by this PR

@rosen-vladimirov rosen-vladimirov merged commit 1ab5241 into master Aug 20, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/merge-rel-master branch August 20, 2019 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants