This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: add ia64 as supported architecture #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ia64 as supported architecture and map it to x86_64 Android arch.
Older runtimes cannot work with ia64 arch (they do not have the x86_64 arch), so check the runtime version and remove the ia64 (and all new archs that we may add in the future).
vakrilov
approved these changes
Aug 20, 2019
|
Failures are not caused by the changes in this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ia64 as supported architecture and map it to x86_64 Android arch.
NOTE: use ia64 only if runtime is 6.0.2 or later …
Older runtimes cannot work with ia64 arch (they do not have the x86_64 arch), so check the runtime version and remove the ia64 (and all new archs that we may add in the future).
PR Checklist
What is the current behavior?
You cannot use snapshot for building ia64 version (x86_64).
What is the new behavior?
In case Android runtime version is 6.0.2 or later, ia64 (x86_64) snapshot will be automatically built.
Related to #1030 and NativeScript/nativescript-cli#4330