Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 628e619

Browse files
Merge pull request #1028 from NativeScript/vladimirov/add-ia64
fix: add ia64 as supported architecture
2 parents aa7902e + 797b77c commit 628e619

File tree

4 files changed

+17
-6
lines changed

4 files changed

+17
-6
lines changed

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-dev-webpack",
3-
"version": "1.1.0",
3+
"version": "1.1.1",
44
"main": "index",
55
"description": "",
66
"homepage": "http://www.telerik.com",

Diff for: plugins/NativeScriptSnapshotPlugin/options.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,16 @@
2828
"default": [
2929
"arm",
3030
"arm64",
31-
"ia32"
31+
"ia32",
32+
"ia64"
3233
],
3334
"items": {
3435
"type": "string",
3536
"enum": [
3637
"arm",
3738
"arm64",
38-
"ia32"
39+
"ia32",
40+
"ia64"
3941
]
4042
}
4143
},

Diff for: snapshot/android/project-snapshot-generator.js

+10-1
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,18 @@ ProjectSnapshotGenerator.prototype.generate = function (generationOptions) {
237237
throw new Error(noV8VersionFoundMessage);
238238
}
239239

240+
// NOTE: Order is important! Add new archs at the end of the array
241+
const defaultTargetArchs = ["arm", "arm64", "ia32", "ia64"];
242+
const runtimeVersion = getAndroidRuntimeVersion(this.options.projectRoot);
243+
if (runtimeVersion && semver.lt(semver.coerce(runtimeVersion), "6.0.2")) {
244+
const indexOfIa64 = defaultTargetArchs.indexOf("ia64");
245+
// Before 6.0.2 version of Android runtime we supported only arm, arm64 and ia32.
246+
defaultTargetArchs.splice(indexOfIa64, defaultTargetArchs.length - indexOfIa64);
247+
}
248+
240249
const options = {
241250
snapshotToolsPath,
242-
targetArchs: generationOptions.targetArchs || ["arm", "arm64", "ia32"],
251+
targetArchs: generationOptions.targetArchs || defaultTargetArchs,
243252
v8Version: generationOptions.v8Version || v8Version,
244253
preprocessedInputFile: generationOptions.preprocessedInputFile,
245254
useLibs: generationOptions.useLibs || false,

Diff for: snapshot/android/snapshot-generator.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ SnapshotGenerator.prototype.preprocessInputFiles = function (inputFiles, outputF
5353
// Example:
5454
// (function() {
5555
// some code here
56-
// })()
56+
// })()
5757
// // sourceMapUrl......
5858
// ** when we join without `;` here, the next IIFE is assumed as a function call to the result of the first IIFE
5959
// (function() {
@@ -101,7 +101,7 @@ SnapshotGenerator.prototype.convertToAndroidArchName = function (archName) {
101101
case "arm": return "armeabi-v7a";
102102
case "arm64": return "arm64-v8a";
103103
case "ia32": return "x86";
104-
case "x64": return "x64";
104+
case "ia64": return "x86_64";
105105
default: return archName;
106106
}
107107
}

0 commit comments

Comments
 (0)