Update app deployment target to 8.0 #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
Fatme
force-pushed
the
fatme/set-deployment-target
branch
from
f7e5214 to
e5d31ff
Compare
|
Test FAILed. |
Fatme
force-pushed
the
fatme/set-deployment-target
branch
from
e5d31ff to
a45b757
Compare
|
Test PASSed. |
|
I suggest that we add a log statement to indicate we've changed the Deployment Target build setting, like we do for adding dynamic frameworks. |
Fatme
force-pushed
the
fatme/set-deployment-target
branch
from
a45b757 to
8d02094
Compare
|
@fealebenpae I added log statement. |
|
Looks good to me. |
|
Test PASSed. |
|
👍 |
| @@ -519,6 +519,11 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ | |||
| if(opts && opts.executePodInstall && this.$fs.exists(pluginPodFilePath).wait()) { | |||
| this.executePodInstall().wait(); | |||
| } | |||
|
|
|||
| let project = this.createPbxProj(); | |||
There was a problem hiding this comment.
You can move this code in a dedicated function
|
👍 after addressing a small, non-functional remark |
Fatme
pushed a commit
that referenced
this pull request
Sep 30, 2015
Update app deployment target to 8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #944