Skip to content

Commit 8d02094

Browse files
Fatme HavaluovaFatme Havaluova
Fatme Havaluova
authored and
Fatme Havaluova
committed
Update app deployment target to 8.0
Fixes #944
1 parent 9e67966 commit 8d02094

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

lib/services/ios-project-service.ts

+5
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,11 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
519519
if(opts && opts.executePodInstall && this.$fs.exists(pluginPodFilePath).wait()) {
520520
this.executePodInstall().wait();
521521
}
522+
523+
let project = this.createPbxProj();
524+
project.updateBuildProperty("IPHONEOS_DEPLOYMENT_TARGET", "8.0");
525+
this.$logger.info("The iOS Deployment Target is now 8.0 in order to support Cocoa Touch Frameworks.");
526+
this.savePbxProj(project).wait();
522527
}).future<void>()();
523528
}
524529

test/ios-project-service.ts

+12
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,12 @@ describe("Cocoapods support", () => {
7676
iOSProjectService.prepareStaticLibs = (pluginPlatformsFolderPath: string, pluginData: IPluginData): IFuture<void> => {
7777
return Future.fromResult();
7878
};
79+
iOSProjectService.createPbxProj = () => {
80+
return {
81+
updateBuildProperty: () => { return {}; }
82+
};
83+
};
84+
iOSProjectService.savePbxProj = (): IFuture<void> => Future.fromResult();
7985

8086
let pluginPath = temp.mkdirSync("pluginDirectory");
8187
let pluginPlatformsFolderPath = path.join(pluginPath, "platforms", "ios");
@@ -137,6 +143,12 @@ describe("Cocoapods support", () => {
137143
iOSProjectService.removeStaticLibs = (pluginPlatformsFolderPath: string, pluginData: IPluginData): IFuture<void> => {
138144
return Future.fromResult();
139145
};
146+
iOSProjectService.createPbxProj = () => {
147+
return {
148+
updateBuildProperty: () => { return {}; }
149+
};
150+
};
151+
iOSProjectService.savePbxProj = (): IFuture<void> => Future.fromResult();
140152

141153
let pluginPath = temp.mkdirSync("pluginDirectory");
142154
let pluginPlatformsFolderPath = path.join(pluginPath, "platforms", "ios");

0 commit comments

Comments
 (0)