Make sure framework dir is part of the cached framework #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| public addToCache(packageName: string, version: string): IFuture<void> { | ||
|
|
||
| public addToCache( packageName: string, version: string): IFuture<void> { |
There was a problem hiding this comment.
The horror - added an empty space after the ( 🙀
|
✅ |
|
👍 |
rosen-vladimirov
force-pushed
the
vladimirov/fix-platform-update
branch
from
61fcd40 to
11e9a59
Compare
|
✅ |
In some cases framework dir is missing in the npm cached package of the framework. Check if it exists and if not, remove the package from the cache and add it again. Fail when the shasum of the package is not correct Fixes #699
rosen-vladimirov
force-pushed
the
vladimirov/fix-platform-update
branch
from
11e9a59 to
955f137
Compare
|
✅ |
rosen-vladimirov
added a commit
that referenced
this pull request
Jul 28, 2015
Make sure framework dir is part of the cached framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases framework dir is missing in the npm cached package of the framework. Check if it exists and if not, remove the package from the cache and add it again.
Fixes #699