Fail when shasum is not correct

Fail when the shasum of the package is not correct.

Author: rosen-vladimirov

lib/npm-installation-manager.ts

@@ -28,18 +28,14 @@ export class NpmInstallationManager implements INpmInstallationManager {
 		return path.join(this.getCacheRootPath(), packageName, version, "package");
 	}
 
-	public addToCache( packageName: string, version: string): IFuture<void> {
+	public addToCache(packageName: string, version: string): IFuture<void> {
 		return (() => {
-			let shasumProperty = "dist.shasum";
 			let cachedPackagePath = this.getCachedPackagePath(packageName, version);
 			if(!this.$fs.exists(cachedPackagePath).wait()) {
 				this.addToCacheCore(packageName, version).wait();
 			}
 
-			let realShasum = this.$npm.view(`${packageName}@${version}`, shasumProperty).wait()[version][shasumProperty];
-			let ourShasum = this.$fs.getFileShasum(cachedPackagePath + ".tgz").wait();
-			this.$logger.trace(`Checking shasum of package: ${packageName}@${version}: expected ${realShasum}, actual ${ourShasum}.`);
-			if(realShasum !== ourShasum) {
+			if(!this.isShasumOfPackageCorrect(packageName, version).wait()) {
 				// In some cases the package is not fully downloaded and the framework directory is missing
 				// Try removing the old package and add the real one to cache again
 				this.addCleanCopyToCache(packageName, version).wait();
@@ -88,6 +84,9 @@ export class NpmInstallationManager implements INpmInstallationManager {
 			this.$logger.trace(`Deleting: ${packagePath}.`);
 			this.$fs.deleteDirectory(packagePath).wait();
 			this.addToCacheCore(packageName, version).wait();
+			if(!this.isShasumOfPackageCorrect(packageName, version).wait()) {
+				this.$errors.failWithoutHelp(`Unable to add package ${packageName} with version ${version} to npm cache. Try cleaning your cache and execute the command again.`)
+			}
 		}).future<void>()();
 	}
 
@@ -101,6 +100,17 @@ export class NpmInstallationManager implements INpmInstallationManager {
 		}).future<void>()();
 	}
 
+	private isShasumOfPackageCorrect(packageName: string, version: string): IFuture<boolean> {
+		return ((): boolean => {
+			let shasumProperty = "dist.shasum";
+			let cachedPackagePath = this.getCachedPackagePath(packageName, version);
+			let realShasum = this.$npm.view(`${packageName}@${version}`, shasumProperty).wait()[version][shasumProperty];
+			let ourShasum = this.$fs.getFileShasum(cachedPackagePath + ".tgz").wait();
+			this.$logger.trace(`Checking shasum of package: ${packageName}@${version}: expected ${realShasum}, actual ${ourShasum}.`);
+			return realShasum === ourShasum;
+		}).future<boolean>()();
+	}
+
 	private installCore(packageName: string, pathToSave: string, version: string): IFuture<string> {
 		return (() => {
 			if (this.$options.frameworkPath) {