Skip to content

Allow the user to manually set Chrome app name #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
"PROXY_PORT": 8888,
"PROXY_HOSTNAME": "127.0.0.1",
"TYPESCRIPT_COMPILER_OPTIONS": {},
"CI_LOGGER": false
"CI_LOGGER": false,
"ANDROID_DEBUG_UI_MAC": "Google Chrome"
}
6 changes: 3 additions & 3 deletions docs/man_pages/project/testing/debug-android.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ Debugs your project on a connected device, in a native emulator or in Genymotion
* `<Emulator Options>` is any valid combination of options as listed by `$ tns help emulate android`
* `<GenyName>` is the name of the Genymotion virtual device that you want to use as listed by `$ genyshell -c "devices list"`

<% if(isHtml) { %>
### Prerequisites
<% if(isHtml) { %>
###Prerequisites

* You must have Chrome installed on your system.
* You must have Chrome installed on your system.<br/>If you are using a non-standard named Chrome app on an OS X system (for example, a nightly Canary update), you need to set this name in the `ANDROID_DEBUG_UI_MAC` setting in the NativeScript [config.json](file:///<%= #{config.getConfigPath(config)} %>).

### Related Commands

Expand Down
2 changes: 1 addition & 1 deletion lib/common
1 change: 1 addition & 0 deletions lib/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export class Configuration extends configBaseLib.ConfigBase implements IConfigur
DEBUG = false;
TYPESCRIPT_COMPILER_OPTIONS = {};
USE_PROXY = false;
ANDROID_DEBUG_UI_MAC = "Google Chrome";

/*don't require logger and everything that has logger as dependency in config.js due to cyclic dependency*/
constructor(protected $fs: IFileSystem) {
Expand Down
4 changes: 3 additions & 1 deletion lib/declarations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ interface IDependencyData {

interface IStaticConfig extends Config.IStaticConfig { }

interface IConfiguration extends Config.IConfig { }
interface IConfiguration extends Config.IConfig {
ANDROID_DEBUG_UI_MAC: string;
}

interface IApplicationPackage {
packageName: string;
Expand Down