Allow the user to manually set Chrome app name #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teobugslayer
force-pushed
the
totev/fix-chrome-mac
branch
from
2715703 to
2180b34
Compare
| @@ -35,6 +35,11 @@ Debugs your project on a connected device, in a native emulator or in Genymotion | |||
|
|
|||
| * You must have Chrome installed on your system. | |||
|
|
|||
| <% if(isMacOS) { %> | |||
There was a problem hiding this comment.
This tag won't work in the current isHtml block as the OS tags work in the console. My advice is to go with a <br/> right next to the period above. In this case, however, you would need to make this "If you are using a non-standard named Chrome app on an OS X system (for example, a nightly Canary update), you need to set this name in the...
Also, please apply code formatting to the setting name.
`this is how you do code formatting`
Update:
This is how it should look like
<% if(isHtml) { %>
###Prerequisites
* You must have Chrome installed on your system.<br/>If you are using a non-standard named Chrome app on an OS X system (for example, a nightly Canary update), you need to set this name in the `ANDROID_DEBUG_UI_MAC` setting in the NativeScript [config.json](file:///<%= #{config.getConfigPath(config)} %>).
### Related Commands
2180b34 to
c4481cd
Compare
|
|
||
| * You must have Chrome installed on your system. | ||
| * You must have Chrome installed on your system.<br/>If you are using a non-standard named Chrome app on an OS X system (for example, a nightly Canary update), | ||
| you need to set this name in the `ANDROID_DEBUG_UI_MAC` setting in the NativeScript [config.json](file:///<%= #{config.getConfigPath(config)} %>). |
There was a problem hiding this comment.
There's an unneeded new line here.
|
👍 |
teobugslayer
force-pushed
the
totev/fix-chrome-mac
branch
from
c4481cd to
a6613c9
Compare
|
✅ |
teobugslayer
added a commit
that referenced
this pull request
Jul 14, 2015
Allow the user to manually set Chrome app name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #632