Fix symlinks that are added to output package and points to not existing location #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
39863a4 to
4d487e8
Compare
|
✅ |
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
4d487e8 to
2d01053
Compare
|
✅ |
| @@ -152,7 +152,7 @@ interface BroccoliNode { | |||
| } | |||
|
|
|||
| interface IBroccoliBuilder { | |||
| prepareNodeModules(outputPath: string, projectDir: string): IFuture<void>; | |||
| prepareNodeModules(outputPath: string, projectDir: string, lastModifiedTime?: any): IFuture<void>; | |||
There was a problem hiding this comment.
The type should not be any but Date:
> fs.statSync("c:\\haxlogs.txt").mtime instanceof Date
true
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
2d01053 to
621c124
Compare
|
✅ |
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
621c124 to
0dd9e67
Compare
|
✅ |
| shell.cp("-R", appSourceDirectoryPath, platformData.appDestinationDirectoryPath); | ||
| _(this.$fs.readDirectory(path.join(platformData.appDestinationDirectoryPath, constants.APP_FOLDER_NAME)).wait()) | ||
| .filter(directoryName => directoryName !== "tns_modules") | ||
| .each(directoryName => this.$fs.deleteDirectory(path.join(platformData.appDestinationDirectoryPath, "app", directoryName)).wait()) |
There was a problem hiding this comment.
"app" => constants.APP_FOLDER_NAME maybe?
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
0dd9e67 to
5cb3eb5
Compare
|
❌ |
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
5cb3eb5 to
81e0d10
Compare
|
✅ |
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
81e0d10 to
17c2a29
Compare
|
✅ |
1 similar comment
|
✅ |
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
2bce7c3 to
ab6a4e2
Compare
|
✅ |
|
👍 |
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
ab6a4e2 to
33cf15b
Compare
|
✅ |
| let currentPreparedTnsModules = this.$fs.readDirectory(absoluteOutputPath).wait(); | ||
| let tnsModulesInApp = this.$fs.readDirectory(path.join(projectDir, "app", "tns_modules")).wait(); | ||
| let modulesToDelete = _.difference(currentPreparedTnsModules, tnsModulesInApp); | ||
| _.each(modulesToDelete, moduleName => this.$fs.deleteDirectory(path.join(absoluteOutputPath, moduleName)).wait()) |
There was a problem hiding this comment.
missing ; at the end
|
👍 one missing |
Fatme
force-pushed
the
fatme/fix-symlinks
branch
from
33cf15b to
7513ad6
Compare
|
✅ |
Fatme
pushed a commit
that referenced
this pull request
Jun 29, 2015
Fix symlinks that are added to output package and points to not existing location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #584
This PR also fixes the pollution in package.json file, removes the need from
tmpfolder and provides a better way for doing incremental prepare of node_modules.