Skip to content

tmp folder not created in root #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tjvantoll opened this issue Jun 26, 2015 · 1 comment
Closed

tmp folder not created in root #599

tjvantoll opened this issue Jun 26, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@tjvantoll
Copy link
Contributor

Hey all,

@jlooper and I discovered some strange behavior when working with the v1.1 CLI. tns run now creates a tmp folder in the folder you execute the command from.

The problem with this is: if you execute run from multiple folders, which I do with my Sublime Text workflow, you end up with multiple copies of this tmp folder. This has a performance impact, as the CLI has to build tmp multiple times, and it's also just kind of strange.

Unless I'm missing something, it seems like tmp should always be created in the root of the project, regardless of the subfolder you execute run in.

Thanks.

@Fatme
Copy link
Contributor

Fatme commented Jun 26, 2015

Hi @tjvantoll,

Here is the PR that fixes this issue - #593.
We've improved our logic when preparing node_modules and don't need tmp directory anymore.
The fix will be included in our 1.1.2 release which is planned for the next week.

@Fatme Fatme added this to the 1.1.2 milestone Jun 26, 2015
@Fatme Fatme added the bug label Jun 26, 2015
@Fatme Fatme self-assigned this Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants