-
-
Notifications
You must be signed in to change notification settings - Fork 197
feat: compute and log build time #5602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rigor789 Please have a look at this PR. Currently, I am logging the build time in seconds. Let me know if I should log the build time in |
Hey @amaaniqbal - seconds is fine, think most tools log in seconds (including fractions) - this looks fine, just want to run this on both ios/android to see it in action, code LGTM 👍 |
This was my intuition too 😄.
Sure, let me know how it works on your end. |
this throws conext:
|
@edusperoni good to know, we can use a different time source I guess, or a polyfill. It is strange however, because according to the node docs, https://nodejs.org/api/perf_hooks.html#performancenow Do you have more context around the error? Can you try running the CI build with Edit: I think we just need to Added it in fade332 - you can test once the CI releases it. |
Yes, that fix solves it. I was just testing it locally and |
@edusperoni I tested the above and worked on my end without the import, using node v15.11.0. 😕 |
@rigor789 I'm using node 14, maybe they changed it in 15? |
PR Checklist
What is the current behavior?
Build time not shown in ios.
What is the new behavior?
Build time is computed and logged irrespective of OS.
Fixes/Implements/Closes #2998.