Skip to content

Doesn't show time taken to build for ios #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ishandutta2007 opened this issue Jul 22, 2017 · 7 comments · Fixed by #5602
Closed

Doesn't show time taken to build for ios #2998

ishandutta2007 opened this issue Jul 22, 2017 · 7 comments · Fixed by #5602
Labels

Comments

@ishandutta2007
Copy link

ishandutta2007 commented Jul 22, 2017

tns build android shows time time taken to complete build but tns build ios doesn't

@rosen-vladimirov
Copy link
Contributor

Hey @ishandutta2007 ,
Thank you for sharing this idea.
Currently the build time for Android is shown on the terminal from the Gradle itself. For iOS, xcodebuild does not print such information by default. I like the idea and it should be pretty straightforward to implement this in CLI's code itself.
In fact, you can try implementing it and send us a pull request, we'll be happy to review it.

@preethamvishy
Copy link

I would like to try this. Is this still up for grabs?

@rosen-vladimirov rosen-vladimirov added the build Describes issues related to build operations label May 22, 2019
@amaaniqbal
Copy link
Contributor

@rosen-vladimirov @pkoleva Should I give this a shot as a part of hacktoberfest?

@rigor789
Copy link
Member

@amaaniqbal feel free to do so 👍

@amaaniqbal
Copy link
Contributor

@rigor789 I couldn't locate exactly where the changes have to be made. Seems like https://github.com/amaaniqbal/nativescript-cli/blob/master/lib/nativescript-cli.ts is the target file.

Could you please help me with locating the changes? I will try to address them accordingly.

@rigor789
Copy link
Member

@amaaniqbal
Copy link
Contributor

Thanks for the pointer @rigor789! I will try creating a PR for this by tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants