fix: prepare of pods should work on case-sensitive systems #5166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there's a case-sensitive file system, the preparation of Podfiles does not work as we check for `iOS` dir in the plugins, but the actual dir is `ios`. Fix the case, add unit tests and remove some unneeded unit test.
In case the hmrData is not passed during initial sync, the code will fail with some unexpected exception. Handle the case and fix unit tests which are successful, but actually throw unhandled error in one of the event handlers.
A unit test messes up the current working directory by creating dir there and does not clean it up. Use temp dir for the test.
|
test cli-run cli-templates |
|
test cli-run cli-templates cli-plugin |
DimitarTachev
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there's a case-sensitive file system, the preparation of Podfiles does not work as we check for
iOSdir in the plugins, but the actual dir isios.Fix the case, add unit tests and remove some unneeded unit test.
Also fix some unit tests.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes issue #5159