Skip to content

applyPluginsCocoaPods fails on case sensitive volumes #5159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leevigraham opened this issue Nov 23, 2019 · 3 comments
Closed

applyPluginsCocoaPods fails on case sensitive volumes #5159

leevigraham opened this issue Nov 23, 2019 · 3 comments
Assignees
Milestone

Comments

@leevigraham
Copy link

leevigraham commented Nov 23, 2019

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.2.2
  • Cross-platform modules: 6.2.1
  • Android Runtime: 6.2.0
  • iOS Runtime: 6.2.0
  • Plugin(s):
Dependencies:
┌──────────────────┬─────────┐
│ Plugin           │ Version │
│ nativescript-vue │ ^2.4.0  │
│ tns-core-modules │ ^6.2.1  │
└──────────────────┴─────────┘
Dev Dependencies:
┌────────────────────────────────────┬─────────┐
│ Plugin                             │ Version │
│ @babel/core                        │ ^7.0.0  │
│ @babel/preset-env                  │ ^7.0.0  │
│ babel-loader                       │ ^8.0.2  │
│ nativescript-dev-webpack           │ ^1.0.0  │
│ nativescript-vue-template-compiler │ ^2.0.0  │
│ nativescript-worker-loader         │ ~0.9.0  │
│ node-sass                          │ ^4.9.2  │
│ vue-loader                         │ ^15.4.0 │
└────────────────────────────────────┴─────────┘

Describe the bug
File: NativeScript/nativescript-cli/blob/master/lib/services/ios-project-service.ts
Method: applyPluginsCocoaPods
Line https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/ios-project-service.ts#L833

This method checks for the pluginPlatformsFolderPath using the normalizedPlatformName which is iOS

In reality the folder names are lowercase:

Example of a plugin:

To Reproduce

  1. Create a new project on a case sensitive drive
  2. run tns platform add ios
  3. run tns prepare ios

Plugin Podfiles are not added.

Expected behavior

Plugin Podfile should be included

@leevigraham
Copy link
Author

Looks like @Fatme and @KristianDD worked on some of this code.

@rosen-vladimirov
Copy link
Contributor

Hey @leevigraham ,
Thanks for reporting this issue. A fix is available in our next version and should be live when we release 6.3.0 release.
Meanwhile you can give it a try by installing the next version of CLI: npm i -g nativescript@next.

@endarova endarova closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants