chore: merge release in master #5165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-trace-log chore: add trace for shouldMigrate caching
…same as the previous one Currently CLI considers the hash that is the same as the previous as invalid and this way the application is restarted on device. As that hash is already handled, we should consider it as a valid hash. Steps to reproduce : ``` `tns create ts_proj` - choose ts tabs project npm i tns-core-modules@rc --save --save-exact npm i nativescript-dev-webpack@rc --save-dev --save-exact node_modules/.bin/update-ns-webpack --deps –configs tns run android Change something in app.android.scss - the change is applied, no restart Change something in app.ios.scss - application restarts ```
fix: handle correctly the situation when the compilation hash is the same as the previous one
chore: create changelog for 6.2.0 release
In Android's resources you can have different `values-v<sdk version>` directories which are used at runtime to differentiate resources for API levels. In CLI we had a logic to include in native build only the `values-v<sdk version>` directories which are equal or lower to the SDK used for building the application. This means that if you are using compileSdk 28, but you have `values-v29` directory in your resources it shouldn't be included in the native build. Due to many changes in the structure of App_Resources/Android and the gradle template in NativeScript 4.0, this logic has been broken. Fix it and execute it on every prepare of App_Resources.
…ering fix: values-v<sdk> directories are not prepared correctly
chore: merge release-patch in release
…reverted to the initial state of application Livesync doesn't work when `tns run ios --no-hmr` command is executed, same changes are synced and the application is reverted to its initial state. On first webpack compilation CLI stores the initial hash of the compilation but the stored hash is updated only in `hmr` mode. On the other side, CLI has a logic to return when the stored hash is the same as the current hash. So, when the changes are reverted to the initial state of the application, the current hash is the same as the first reported hash. This way, CLI doesn't execute any livesync logic after the reported changes from webpack process. Rel to: #5132
fix: fix livesync when `--no-hmr` option is provided and changes are reverted to the initial state of application
In case we do not have some of iOS Resource images in our image-definitions.json file, we do not generate images for them. This was not the case prior 6.2.0 release, so fix the behavior by getting back the old logic - get the image size from the Contents.json and generate image for it. Also add the images from the templates that are currently missing from our `image-definitions.json` file.
chore: create changelog for 6.2.1 release
…ation-2 fix: generate iOS images when we have their sizes
Add script to generate the changelog automatically. The script should be called from the root of the repository in the following way: ``` node generate_changelog.js <milestone> <GitHub Access Token which has read access to repository> ``` For example: ``` node generate_changelog.js 6.2.2 2d2156c261bb1494f7a6e22f11fa446c7ca0e6b7 ``` The script uses GitHub's GraphQL API v4. More information about it can be found [here](https://developer.github.com/v4/). The script is designed to work with current NativeScript CLI workflow: - it generates changelog based on CLI's Changelog.md format - it generates changelog only for issues, PR's added in the milestone are not included in the changelog - issues with no-changelog label are not added to the milestone. A warning is shown for them. - issues with feature label are added to the "New" section of the changelog. All other issues are added to the "Fixed" section. - issues, which are not in state "Ready for Test", "In testing" or "Done" are not added to the changelog. A warning is shown for them.
…log-generation chore: add script for automatic changelog generation
chore: Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].