fix: values-v<sdk> directories are not prepared correctly #5121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Android's resources you can have different `values-v<sdk version>` directories which are used at runtime to differentiate resources for API levels. In CLI we had a logic to include in native build only the `values-v<sdk version>` directories which are equal or lower to the SDK used for building the application. This means that if you are using compileSdk 28, but you have `values-v29` directory in your resources it shouldn't be included in the native build. Due to many changes in the structure of App_Resources/Android and the gradle template in NativeScript 4.0, this logic has been broken. Fix it and execute it on every prepare of App_Resources.
|
test cli-templates cli-run cli-smoke |
DimitarTachev
approved these changes
Nov 8, 2019
|
test cli-run |
|
test cli-templates |
1 similar comment
|
test cli-templates |
|
merging as failing test is not caused by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android's resources you can have different
values-v<sdk version>directories which are used at runtime to differentiate resources for API levels.In CLI we had a logic to include in native build only the
values-v<sdk version>directories which are equal or lower to the SDK used for building the application.This means that if you are using compileSdk 28, but you have
values-v29directory in your resources it shouldn't be included in the native build.Due to many changes in the structure of App_Resources/Android and the gradle template in NativeScript 4.0, this logic has been broken.
Fix it and execute it on every prepare of App_Resources.
PR Checklist
What is the current behavior?
What is the new behavior?
CLI prepares values-v directories based on the current compileSdk
Fixes issue #5120