Skip to content

fix: tns update will not modify webpack.config.js of React/Svelte projects #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

As both React and Svelte projects have custom webpack.config.js files, when tns update replaces the webpack.config.js file, the project becomes unusable. We do not have default webpack.config.js files for these templates, so for the momennt skip the replacement of the file during tns update and print informational warning.

PR Checklist

What is the current behavior?

Executing tns upate in React-nativescript or Svelte project replaces the webpack.config.js with default one for our JavaScript template. This makes the projects unusable and broken.

What is the new behavior?

CLI prints a warning during tns update that it will not update the webpack.config.js file as the project type is React or Svelte

Fixes comment #4947 (comment)

…jects

As both React and Svelte projects have custom webpack.config.js files, when `tns update` replaces the `webpack.config.js` file, the project becomes unusable. We do not have default webpack.config.js files for these templates, so for the momennt skip the replacement of the file during `tns update` and print informational warning.
@Fatme Fatme merged commit b419c21 into master Aug 27, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/update-react-svelte branch January 17, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants