fix: tns update will not modify webpack.config.js of React/Svelte projects #4981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As both React and Svelte projects have custom webpack.config.js files, when
tns update
replaces thewebpack.config.js
file, the project becomes unusable. We do not have default webpack.config.js files for these templates, so for the momennt skip the replacement of the file duringtns update
and print informational warning.PR Checklist
What is the current behavior?
Executing
tns upate
in React-nativescript or Svelte project replaces the webpack.config.js with default one for our JavaScript template. This makes the projects unusable and broken.What is the new behavior?
CLI prints a warning during
tns update
that it will not update thewebpack.config.js
file as the project type isReact
orSvelte
Fixes comment #4947 (comment)