Skip to content

Add tracking for both React NativeScript and Svelte Native projects #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rdlauer opened this issue Aug 13, 2019 · 5 comments
Closed

Add tracking for both React NativeScript and Svelte Native projects #4947

rdlauer opened this issue Aug 13, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@rdlauer
Copy link
Contributor

rdlauer commented Aug 13, 2019

We should start tracking usage of the new community-driven React NativeScript and Svelte Native initiatives in the CLI.

@etabakov
Copy link
Contributor

Let's track those as "React" and "Svelte" respectively.

@rosen-vladimirov
Copy link
Contributor

rosen-vladimirov commented Aug 19, 2019

Acceptance Criteria:

  • Projects created as described in https://github.com/shirakaba/react-nativescript#setup should be tracked as "React"
  • Projects created as described in https://svelte-native.technology/ should be tracked as "Svelte"
  • JS or TS projects (without nativescript-angular or nativescript-vue in them) should be tracked as React after npm install react-nativescript --save is executed.
  • JS or TS projects (without nativescript-angular or nativescript-vue in them) should be tracked as Svelte after npm install svelte-native --save is executed.
  • Project which is tracked as React or Svelte should be available for tns update command, i.e. when you execute the tns update in such project, it should pass and update your tns-core-modules, runtimes and nativescript-dev-webpack versions.

NOTE: You can check how CLI tracks each project by checking the cd2 value in the analyticsLogFile, i.e.:

tns usage-reporting enable
tns prepare <platform> --analyticsLogFile analyticsData.txt

After command exits check the analyticsData.txt file and search for:

Setting custom dimension cd2 to value Svelte

or

Setting custom dimension cd2 to value React

@shirakaba
Copy link

Not sure if this is the best place for it, but either way, here's a starter template for React NativeScript. The commit history shows how I built it following tns create mycoolapp --tsc.

It follows the steps of https://github.com/shirakaba/react-nativescript#setup exactly, except for the fact that I've pinned the installed dependency versions.

https://github.com/shirakaba/react-nativescript-starter

@rosen-vladimirov rosen-vladimirov self-assigned this Aug 20, 2019
@etabakov
Copy link
Contributor

Hey Jamie, that's great! I will open a separate issue to keep this issue focused on tracking.

@miroslavaivanova
Copy link
Contributor

When use command tns update and run
tns usage-reporting enable
tns prepare <platform> --analyticsLogFile analyticsData.txt
You will see exception with update of webpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants