Skip to content

feat: add tracking for React and Svelte projecs #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

Add tracking in CLI analytics for React and Svelte project types. As we do not have templates for those two project types, when CLI detects a project from this type and the tns update command is executed, get the dependencies for update from the default hellow world JS template.

PR Checklist

What is the current behavior?

CLI does not track React and Svelte projects

What is the new behavior?

CLI tracks projects as React when react-nativescript is added as dependency.
CLI tracks projects as Svelte when svelte-native is added as dependency.

Implements issue: #4947

Add tracking in CLI analytics for React and Svelte project types. As we do not have templates for those two project types, when CLI detects a project from this type and the `tns update` command is executed, get the dependencies for update from the default hellow world JS template.
@rosen-vladimirov rosen-vladimirov added this to the 6.1.0 milestone Aug 19, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Aug 19, 2019
@cla-bot cla-bot bot added the cla: yes label Aug 19, 2019
@rosen-vladimirov
Copy link
Contributor Author

test cli-run cli-smoke cli-misc cli-templates cli-debug

@DimitarTachev DimitarTachev merged commit 50d1af6 into master Aug 21, 2019
@DimitarTachev DimitarTachev deleted the vladimirov/tracking-project-types branch August 21, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants