chore: merge release in master #4851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we've already moved the logic for validation the version of nativescript-dev-webpack plugin to commandsService, there is no need to validate it again from commands.
…ipt-dev-webpack is lower than 1.0.0
In case there are multiple devices with the same platform, `run command` fails with error `Cannot read property hasNativeChanges of undefined`. The problem is that we return incorrect prepare data. Also we have a problem in `tns preview` when multiple platforms are used - all files are send multiple times to each device as we have too many started webpack processes (in case you scan fast with devices) and we are also adding handler of the prepare ready event per each device instead per platform. Fix this by handling the event only once per platform
the message is shown every time when we want to show a line from device logs and we are with trace level
fix: preview and run do not work correctly
…sion feat: validate the version of nativescript-dev-webpack plugin on every command
The `before-preview-sync` hook has incorrect args - instead of having `hookArgs`, it has an object with data. This causes issues in all plugins which are using it. Get back the correct structure and add `projectData` as it is being used by kinvey-nativescript-sdk's hook.
fix: before-preview-sync hook has incorrect args
…ceDescriptors as param to sync method
When you run your app on iOS device for the first time, we execute full sync operation with a zip file. This does not gets in our logic for setting source maps of the transferred files and CLI does not use its logic to parse device logs and show the exact lines from original files. Fix this by setting the source maps in this case.
fix: iOS device logs are not using source maps initially
…pNativePlatform is provided
In case migrate command fails to migrate the project, currently it shows some generic message without saying what is the actual error. Also the command exits with code 0, which is indication it had succeeded. Fix this by failing with more descriptive error message and exit code that is not 0.
When hook throws an error, there's no easy way to find exactly what is failing as CLI overwrites the error and its callstack. As it is not trivial solution to stop CLI of doing this, when a hook fails, just log the error with its callstack. We know these errors always lead to stopage of CLI process, so we can safely print them.
fix: migrate command failure should be handled correctly
fix: show the actual error when hook fails
fix: make the update command behave similar to the logic before 6.0.0
Currently `tns cloud deploy` command starts local build as the provided buildAction through deviceDescriptor is not executed from deployController.
In case you've installed `nativescript-unit-test-runner` , but you've not used `tns test init`, `tns migrate` command fails with error: `Could not migrate the project! The error is: Error: ENOENT: no such file or directory, open '<project dir>/.migration_backup/karma.conf.js'` Skip the migration of the `karma.conf.js` file in case it is missing. Also, ensure `karma-webpack` is always added by the migration when `nativescript-unit-test-runner` is migrated.
…t-test fix: migrate fails when karma.config.js is missing
…he pre 4.0 structure
fix: migrate validation issues
…cloud build Currently the application is built every time from sidekick when opening the app and starting cloud build. This happens as we decided that there are changes in app_resources as `prepareData.release` is undefined but `prepareInfo.release` is false. This way the check `prepareData.release !== this._prepareInfo.release` passes and we set `this._changesInfo.appResourcesChanged` to `true`.
Co-Authored-By: Dimitar Tachev <[email protected]>
fix: add the link to blog post
…kick fix: don't build every time the application from sidekick when using cloud build
…t build causing an invalid build
…lid-tag Kddimitrov/fix update invalid tag
fix: disable the `watch` in release builds as its triggering 2 snapshot generations
…dependencies chore: update migrate dependencies
…atform-status fix: fix the missing icons in newly created apps on iOS devices
Currently when livesync is started on iOS device from sidekick, {N} CLI persist that livesync is started for iOS platform. After that if the livesync process is started on android device, {N} CLI overrides the persisted platforms and stores that the livesync is started for Android platform. However, when the livesync is stopped, {N} CLI stops it only for android platform. This means that the iOS webpack process is alive and continues to report data. This led to the multiple livesync messages when syncing the changes.
…orce feat: skip migration check based on --force
…c-sidekick fix: stop all webpack processes from sidekick when stopping the livesync
KristianDD
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.