fix: before-preview-sync hook has incorrect args #4803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `before-preview-sync` hook has incorrect args - instead of having `hookArgs`, it has an object with data. This causes issues in all plugins which are using it. Get back the correct structure and add `projectData` as it is being used by kinvey-nativescript-sdk's hook.
Fatme
approved these changes
Jul 4, 2019
|
test cli-preview package_version#rc |
2 similar comments
|
test cli-preview package_version#rc |
|
test cli-preview package_version#rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
before-preview-synchook has incorrect args - instead of havinghookArgs, it has an object with data. This causes issues in all plugins which are using it. Get back the correct structure and addprojectDataas it is being used by kinvey-nativescript-sdk's hook.PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].