fix: debug android --start should allow to debug #4774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tns debug android --start` should allow you to debug. However, immediately after opening the debug socket we set the cleanupService to clean the forwarded port once CLI process exits. As we have not set the cleanupService in long living mode, CLI calls injector.dispose and this cleans the debug socket. To handle this, just set the cleanupService in long living mode.
|
test cli-debug |
Fatme
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tns debug android --startshould allow you to debug. However, immediately after opening the debug socket we set the cleanupService to clean the forwarded port once CLI process exits. As we have not set the cleanupService in long living mode, CLI calls injector.dispose and this cleans the debug socket.To handle this, just set the cleanupService in long living mode.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].