Merge pull request #4774 from NativeScript/vladimirov/fix-debug-start

fix: debug android --start should allow to debug

Author: rosen-vladimirov

lib/commands/debug.ts

@@ -12,13 +12,15 @@ export class DebugPlatformCommand extends ValidatePlatformCommandBase implements
 		$projectData: IProjectData,
 		$options: IOptions,
 		$platformsDataService: IPlatformsDataService,
+		$cleanupService: ICleanupService,
 		protected $logger: ILogger,
 		protected $errors: IErrors,
 		private $debugDataService: IDebugDataService,
 		private $debugController: IDebugController,
 		private $liveSyncCommandHelper: ILiveSyncCommandHelper,
 		private $androidBundleValidatorHelper: IAndroidBundleValidatorHelper) {
 		super($options, $platformsDataService, $platformValidationService, $projectData);
+		$cleanupService.setShouldDispose(false);
 	}
 
 	public async execute(args: string[]): Promise<void> {
@@ -87,16 +89,14 @@ export class DebugIOSCommand implements ICommand {
 		private $sysInfo: ISysInfo,
 		private $projectData: IProjectData,
 		$iosDeviceOperations: IIOSDeviceOperations,
-		$iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider,
-		$cleanupService: ICleanupService) {
+		$iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider) {
 		this.$projectData.initializeProjectData();
 		// Do not dispose ios-device-lib, so the process will remain alive and the debug application (NativeScript Inspector or Chrome DevTools) will be able to connect to the socket.
 		// In case we dispose ios-device-lib, the socket will be closed and the code will fail when the debug application tries to read/send data to device socket.
 		// That's why the `$ tns debug ios --justlaunch` command will not release the terminal.
 		// In case we do not set it to false, the dispose will be called once the command finishes its execution, which will prevent the debugging.
 		$iosDeviceOperations.setShouldDispose(false);
 		$iOSSimulatorLogProvider.setShouldDispose(false);
-		$cleanupService.setShouldDispose(false);
 	}
 
 	public execute(args: string[]): Promise<void> {