chore: merge release in master #4365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of throwing an exception
docs: add missing resources command in index
fix: shouldRestart will now return true if the app is not running instead of throwing an exception
docs: update CHANGELOG for 5.2.0
fix: update lodash because of "a potential security vulnerability"
In case there's no ANDROI_HOME on user's machine, CLI tries to use its local copy of adb. However, the current path to adb is not correct and CLI does not work with any Android devices in this case. Fix the path to local copy of adb.
…te-adb fix: cli's local adb is not used
chore: merge release-patch in release
In case `--bundle` is passed CLI tries to clean the `tns_modules` directory produced from previous prepare operations. However, this is not required in latest versions as webpack cleans the directory on its own. The current clean was required for Webpack before 0.14.0, particularly the one used with 3.x versions of NativeScript. Delete unit test that is no longer relevant, as it tests functionality that is now handled by `nativescript-dev-webpack` plugin.
…s_modules chore: skip tns_modules cleanup from CLI
|
run ci |
3 similar comments
|
run ci |
|
run ci |
|
run ci |
miroslavaivanova
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: merge release in master