fix: cli's local adb is not used #4359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there's no ANDROI_HOME on user's machine, CLI tries to use its local copy of adb. However, the current path to adb is not correct and CLI does not work with any Android devices in this case. Fix the path to local copy of adb.
rosen-vladimirov
added
bug
no-changelog
KristianDD
approved these changes
Feb 11, 2019
miroslavaivanova
approved these changes
Feb 11, 2019
|
Merging without waiting for |
dtopuzov
added a commit
to NativeScript/nativescript-tooling-qa
that referenced
this pull request
Feb 11, 2019
dtopuzov
added a commit
to NativeScript/nativescript-tooling-qa
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there's no ANDROI_HOME on user's machine, CLI tries to use its local copy of adb. However, the current path to adb is not correct and CLI does not work with any Android devices in this case.
Fix the path to local copy of adb.
PR Checklist
What is the current behavior?
When you do not have ANDROID_HOME set and Android device is attached, CLI does not discover it, i.e.
tns deviceswill not show the devices.What is the new behavior?
When you do not have ANDROID_HOME set and Android device is attached, CLI will discover it, i.e.
tns deviceswill show the device.