feat: track data from preview app on preview and run commands
#4287
+137
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
KristianDD
reviewed
Jan 16, 2019
| @@ -63,6 +90,10 @@ process.on("message", async (data: ITrackingInformation) => { | |||
| return; | |||
| } | |||
|
|
|||
| if (data.type === TrackingTypes.PreviewAppData) { | |||
| await trackPreviewAppData(<IPreviewAppTrackingInformation>data); | |||
|
Update |
|
run ci |
Fatme
force-pushed
the
fatme/track-data-from-preview-app
branch
3 times, most recently
from
c9e7d51 to
c21eb24
Compare
|
run ci |
Fatme
force-pushed
the
fatme/track-data-from-preview-app
branch
from
c21eb24 to
56ec5fc
Compare
|
run ci |
rosen-vladimirov
approved these changes
Jan 28, 2019
|
Can you please rebase before merging, as we have a lot of commits in master and it will be great in case these commits are at the top of the tree |
{N} CLI checks if there is a file on device written from preview app, gets its content if such file exists and sends an event to google analytics. This will allow us to know how much users are using the Playground site and {N} CLI.
Fatme
force-pushed
the
fatme/track-data-from-preview-app
branch
from
d45cfa3 to
973662f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{N} CLI checks if there is a file on device written from preview app, gets its content if such file exists and sends an event to google analytics. This will allow us to know how much users are using the Playground site and {N} CLI.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].