Skip to content

Commit c21eb24

Browse files
committed
chore: fix unit tests and update nativescript-preview-sdk
1 parent 7228f6b commit c21eb24

File tree

5 files changed

+163
-135
lines changed

5 files changed

+163
-135
lines changed

lib/services/livesync/playground/preview-app-livesync-service.ts

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as path from "path";
22
import { Device, FilesPayload } from "nativescript-preview-sdk";
3-
import { AnalyticsEventLabelDelimiter, APP_RESOURCES_FOLDER_NAME, APP_FOLDER_NAME, TrackActionNames } from "../../../constants";
3+
import { APP_RESOURCES_FOLDER_NAME, APP_FOLDER_NAME, TrackActionNames } from "../../../constants";
44
import { PreviewAppLiveSyncEvents } from "./preview-app-constants";
55
import { HmrConstants } from "../../../common/constants";
66
import { stringify } from "../../../common/helpers";
@@ -34,12 +34,11 @@ export class PreviewAppLiveSyncService extends EventEmitter implements IPreviewA
3434
this.$errors.failWithoutHelp("Sending initial preview files without a specified device is not supported.");
3535
}
3636

37-
const deviceUniqueId = (<any>device).uniqueId;
38-
if (deviceUniqueId) {
39-
this.$analyticsService.trackEventActionInGoogleAnalytics({
37+
if (device.uniqueId) {
38+
await this.$analyticsService.trackEventActionInGoogleAnalytics({
4039
action: TrackActionNames.PreviewAppData,
4140
platform: device.platform,
42-
additionalData: `previewAppDeviceId${AnalyticsEventLabelDelimiter}${deviceUniqueId}`
41+
additionalData: device.uniqueId
4342
});
4443
}
4544

0 commit comments

Comments
 (0)