chore: update the interactive create descriptions based on the DevRel feedback. #4013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
force-pushed
the
tachev/improve-create-readme
branch
from
8e27688 to
e8b7759
Compare
Fatme
reviewed
Oct 11, 2018
test/project-commands.ts
Outdated
| @@ -85,12 +85,12 @@ describe("Project commands tests", () => { | |||
| answers["First, what will be the name of your app?"] = opts.projectNameAnswer; | |||
| } | |||
| if (opts.flavorAnswer) { | |||
| const flavorQuestion = opts.projectNameAnswer ? "Next" : "First" + ", which flavor would you like to use?"; | |||
| const flavorQuestion = opts.projectNameAnswer ? "Next" : "First" + ", which style of NativeScript project would you like to use:"; | |||
There was a problem hiding this comment.
Why do you need + here?
const flavorQuestion = opts.projectNameAnswer ? "Next" : "First, which style of NativeScript project would you like to use:";
There was a problem hiding this comment.
Copy-paste :)
Fatme
approved these changes
Oct 11, 2018
DimitarTachev
force-pushed
the
tachev/improve-create-readme
branch
from
e8b7759 to
747449e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Related to #3969