feat: interactive app creation #3969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
reviewed
Oct 3, 2018
lib/commands/create-project.ts
Outdated
| } | ||
|
|
||
| private getNgFlavors() { | ||
| const templates: { |
There was a problem hiding this comment.
const templates = [
{
key: CreateProjectCommand.HelloWorldTemplateKey,
value: "tns-template-hello-world-ng",
description: CreateProjectCommand.HelloWorldTemplateDescription
},
{
key: CreateProjectCommand.DrawerTemplateKey,
value: "tns-template-drawer-navigation-ng",
description: CreateProjectCommand.DrawerTemplateDescription
},
{
key: CreateProjectCommand.TabsTemplateKey,
value: "tns-template-tab-navigation-ng",
description: CreateProjectCommand.TabsTemplateDescription
}
];
return templates;
DimitarTachev
force-pushed
the
tachev/interactive-create
branch
2 times, most recently
from
b2e3a57 to
807f1cc
Compare
DimitarTachev
force-pushed
the
tachev/interactive-create
branch
from
807f1cc to
b470c6c
Compare
rosen-vladimirov
suggested changes
Oct 3, 2018
There was a problem hiding this comment.
- Add more tests for each of the combination of choices in the prompters.
- New
--options should be described in the help oftns createcommand - New behavior should be described in the help of
tns createcommand. I suggest to place there the names of the templates that we are using for each option.
lib/services/project-service.ts
Outdated
| @exported("projectService") | ||
| public async createProject(projectOptions: IProjectSettings): Promise<ICreateProjectData> { | ||
| let projectName = projectOptions.projectName; | ||
| projectName = await this.validateProjectName({ projectName, force: projectOptions.force, pathToProject: projectOptions.pathToProject }); |
There was a problem hiding this comment.
const projectName = await this.validateProjectName({ projectName: projectOptions.projectName, force: projectOptions.force, pathToProject: projectOptions.pathToProject });
lib/commands/create-project.ts
Outdated
|
|
||
| export class CreateProjectCommand implements ICommand { | ||
| public enableHooks = false; | ||
| public allowedParameters: ICommandParameter[] = [this.$stringParameterBuilder.createMandatoryParameter("Project name cannot be empty.")]; | ||
| public allowedParameters: ICommandParameter[] = [this.$stringParameter]; | ||
| private static NgFlavor = "Angular"; |
There was a problem hiding this comment.
You can move some of these in constants and reuse them here, in the tests and here
lib/commands/create-project.ts
Outdated
| private getTsTemplates() { | ||
| const templates = [{ | ||
| key: CreateProjectCommand.HelloWorldTemplateKey, | ||
| value: "tns-template-hello-world-ts", |
There was a problem hiding this comment.
RESERVED_TEMPLATE_NAMES.typescript
lib/commands/create-project.ts
Outdated
| private getJsTemplates() { | ||
| const templates = [{ | ||
| key: CreateProjectCommand.HelloWorldTemplateKey, | ||
| value: "tns-template-hello-world", |
There was a problem hiding this comment.
RESERVED_TEMPLATE_NAMES.javascript
lib/commands/create-project.ts
Outdated
| private getNgFlavors() { | ||
| const templates = [{ | ||
| key: CreateProjectCommand.HelloWorldTemplateKey, | ||
| value: "tns-template-hello-world-ng", |
There was a problem hiding this comment.
RESERVED_TEMPLATE_NAMES.angular
lib/services/project-service.ts
Outdated
|
|
||
| const selectedPath = path.resolve(projectOptions.pathToProject || "."); | ||
| private getValidProjectDir(pathToProject: string, projectName: string): string { |
There was a problem hiding this comment.
private methods should be below public ones
DimitarTachev
force-pushed
the
tachev/interactive-create
branch
from
d654e44 to
1cb0323
Compare
rosen-vladimirov
approved these changes
Oct 8, 2018
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Related to #3829
BREAKING CHANGES:
tns createwithout any framework or template flags (--ng, --tsc or --template) will now ask a few questions for selecting the proper template.