feat: set min required compile Android SDK to 28 #3992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are going to set min required Android Support Library to be 28 (in the modules), we need to set the min required compile SDK to 28 as well (as Android Support Library 28 relies on resources included in this version of the SDK and the project cannot be build without them). This way CLI will not allow building an application without installing the Android SDK 28 first.
PR Checklist
What is the current behavior?
CLI allows you to build applications when Android SDK 28 is not installed. Using next of tns-core-modules and trying to build it will fail with some missing resources error.
What is the new behavior?
CLI does not allow you to build applications in case Android SDK 28 is not installed.
Implements issue #3991
BREAKING CHANGES:
You will not be able to build applications for Android without installing SDK 28
Migration steps:
Install Android SDK 28 and build tools 28: