Skip to content

feat: set min required compile Android SDK to 28 #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

As we are going to set min required Android Support Library to be 28 (in the modules), we need to set the min required compile SDK to 28 as well (as Android Support Library 28 relies on resources included in this version of the SDK and the project cannot be build without them). This way CLI will not allow building an application without installing the Android SDK 28 first.

PR Checklist

What is the current behavior?

CLI allows you to build applications when Android SDK 28 is not installed. Using next of tns-core-modules and trying to build it will fail with some missing resources error.

What is the new behavior?

CLI does not allow you to build applications in case Android SDK 28 is not installed.
Implements issue #3991

BREAKING CHANGES:
You will not be able to build applications for Android without installing SDK 28

Migration steps:
Install Android SDK 28 and build tools 28:

$ANDROID_HOME/tools/bin/sdkmanager "build-tools;28.0.1"
$ANDROID_HOME/tools/bin/sdkmanager "platforms;android-28"

@rosen-vladimirov rosen-vladimirov added this to the 5.0.0 milestone Oct 8, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this Oct 8, 2018
As we are going to set min required Android Support Library to be 28 (in the modules), we need to set the min required compile SDK to 28 as well (as Android Support Library 28 relies on resources included in this version of the SDK and the project cannot be build without them). This way CLI will not allow building an application without installing the Android SDK 28 first.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/min-compile-sdk-28 branch from 196edf3 to 88c8028 Compare October 8, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants