Skip to content

Commit 196edf3

Browse files
feat: set min required compile Android SDK to 28
As we are going to set min required Android Support Library to be 28 (in the modules), we need to set the min required compile SDK to 28 as well (as Android Support Library 28 relies on resources included in this version of the SDK and the project cannot be build without them). This way CLI will not allow building an application without installing the Android SDK 28 first.
1 parent 535471f commit 196edf3

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

lib/android-tools-info.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class AndroidToolsInfo implements IAndroidToolsInfo {
1818
"android-27",
1919
"android-28",
2020
];
21-
private static MIN_REQUIRED_COMPILE_TARGET = 22;
21+
private static MIN_REQUIRED_COMPILE_TARGET = 28;
2222
private static REQUIRED_BUILD_TOOLS_RANGE_PREFIX = ">=23";
2323
private static VERSION_REGEX = /((\d+\.){2}\d+)/;
2424

npm-shrinkwrap.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"minimatch": "3.0.2",
5656
"mkdirp": "0.5.1",
5757
"mute-stream": "0.0.5",
58-
"nativescript-doctor": "1.5.0",
58+
"nativescript-doctor": "1.6.0",
5959
"nativescript-preview-sdk": "0.2.18",
6060
"open": "0.0.5",
6161
"ora": "2.0.0",

0 commit comments

Comments
 (0)