Skip to content

fix: run ios fails if tns-ios version contains tags #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

KristianDD
Copy link
Contributor

PR Checklist

What is the current behavior?

tns run ios command will fail with:
Unable to apply changes on device: xxxxxx. Error is: Invalid Version: rc.

What is the new behavior?

The application will be build and deployed

Fixes/Implements/Closes #3803.

@KristianDD KristianDD changed the title fix: cloud run fails if tns-ios version contains tags fix: run ios fails if tns-ios version contains tags Aug 7, 2018
@KristianDD KristianDD force-pushed the kddimitrov/fix-cloud-run-ios-tag-version branch from ce13908 to d2d1ddb Compare August 7, 2018 14:09
Copy link
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also add some unit tests for regression testing

@rosen-vladimirov rosen-vladimirov merged commit d3bd0e9 into release Aug 7, 2018
@rosen-vladimirov rosen-vladimirov deleted the kddimitrov/fix-cloud-run-ios-tag-version branch August 7, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants