Skip to content

Commit d3bd0e9

Browse files
Merge pull request #3804 from NativeScript/kddimitrov/fix-cloud-run-ios-tag-version
fix: run ios fails if tns-ios version contains tags
2 parents d22ad0d + d2d1ddb commit d3bd0e9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/services/ios-debugger-port-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export class IOSDebuggerPortService implements IIOSDebuggerPortService {
5252
private canStartLookingForDebuggerPort(data: IProjectDir): boolean {
5353
const projectData = this.$projectDataService.getProjectData(data && data.projectDir);
5454
const frameworkVersion = this.$iOSProjectService.getFrameworkVersion(projectData);
55-
return !frameworkVersion || semver.gt(frameworkVersion, IOSDebuggerPortService.MIN_REQUIRED_FRAMEWORK_VERSION);
55+
return !frameworkVersion || !semver.valid(frameworkVersion) || semver.gt(frameworkVersion, IOSDebuggerPortService.MIN_REQUIRED_FRAMEWORK_VERSION);
5656
}
5757

5858
@cache()

lib/services/livesync/livesync-service.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,6 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
459459
const platformLiveSyncService = this.getLiveSyncService(platform);
460460
const deviceBuildInfoDescriptor = _.find(deviceDescriptors, dd => dd.identifier === device.deviceInfo.identifier);
461461

462-
await platformLiveSyncService.prepareForLiveSync(device, projectData, liveSyncData, deviceBuildInfoDescriptor.debugOptions);
463-
464462
await this.ensureLatestAppPackageIsInstalledOnDevice({
465463
device,
466464
preparedPlatforms,
@@ -474,6 +472,8 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
474472
env: liveSyncData.env
475473
}, { skipNativePrepare: deviceBuildInfoDescriptor.skipNativePrepare });
476474

475+
await platformLiveSyncService.prepareForLiveSync(device, projectData, liveSyncData, deviceBuildInfoDescriptor.debugOptions);
476+
477477
const liveSyncResultInfo = await platformLiveSyncService.fullSync({
478478
projectData, device,
479479
syncAllFiles: liveSyncData.watchAllFiles,

0 commit comments

Comments
 (0)