Skip to content

Merge release in master before 0.9.2 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 13, 2015

Conversation

rosen-vladimirov
Copy link
Contributor

Merge release in master before 0.9.2

Add config.json file inside new config directory. This file is required in order to allow user specific configurations. Modify nativescript-cli.ts in order to wrap resolving of config and errors inside fiber as the new implementation of config has .wait().

Update common lib, where the following changes are applied:
Rename the following config options:
 - FIDDLER_HOSTNAME to PROXY_HOSTNAME
 - PROXY_TO_FIDDLER to USE_PROXY

Add PROXY_PORT option to config with default value 8888. Add ConfigBase class which should be used as a base for CLI specific configs.

Required for #297 and #302
…tings

Enable proxy using for http requests
Update common lib, where the following change is applied: Set userAgentString to (osType). For example on Linux the agent will be (Linux).
ConfigBase implements Config.IConfig. Fix Configuration extends ConfigBase and implements IConfiguration.
@ns-bot
Copy link

ns-bot commented Mar 13, 2015

Test PASSed.

@Fatme
Copy link
Contributor

Fatme commented Mar 13, 2015

👍

rosen-vladimirov added a commit that referenced this pull request Mar 13, 2015
@rosen-vladimirov rosen-vladimirov merged commit 7289922 into master Mar 13, 2015
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/merge-rel-pre-0.9.2 branch March 13, 2015 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants