Enable proxy using for http requests #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| }); | ||
| export class Configuration extends configBaseLib.ConfigBase { // User specific config | ||
| CI_LOGGER = false; | ||
| DEBUG = process.env.NATIVESCRIPT_DEBUG; |
There was a problem hiding this comment.
process.env.NATIVESCRIPT_DEBUG is unneeded, we can set DEBUG = false
|
👍 |
|
I think this must be documented and communicated to users of tns. @ikoevska @ErjanGavalji your opinion? |
Add config.json file inside new config directory. This file is required in order to allow user specific configurations. Modify nativescript-cli.ts in order to wrap resolving of config and errors inside fiber as the new implementation of config has .wait(). Update common lib, where the following changes are applied: Rename the following config options: - FIDDLER_HOSTNAME to PROXY_HOSTNAME - PROXY_TO_FIDDLER to USE_PROXY Add PROXY_PORT option to config with default value 8888. Add ConfigBase class which should be used as a base for CLI specific configs. Required for #297 and #302
rosen-vladimirov
force-pushed
the
vladimirov/enable-proxy-settings
branch
from
68a00fa to
af35703
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Mar 13, 2015
…tings Enable proxy using for http requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config.json file inside new config directory. This file is required in order to allow user specific configurations. Modify nativescript-cli.ts in order to wrap resolving of config and errors inside fiber as the new implementation of config has .wait().
Update common lib, where the following changes are applied:
Rename the following config options:
Add PROXY_PORT option to config with default value 8888. Add ConfigBase class which should be used as a base for CLI specific configs.
Required for #297 and #302