Skip to content

Stop stopping device detection interval #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Stop stopping device detection interval #2646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/common
Open in desktop
Submodule common updated 9 files
+3 −6 appbuilder/services/livesync/livesync-service.ts
+3 −3 appbuilder/services/npm-service.ts
+0 −74 decorators.ts
+19 −1 definitions/mobile.d.ts
+15 −27 mobile/mobile-core/devices-service.ts
+2 −2 services/typescript-service.ts
+57 −275 test/unit-tests/decorators.ts
+0 −40 test/unit-tests/mobile/devices-service.ts
+2 −2 test/unit-tests/mocks/public-api-mocks.ts
4 changes: 1 addition & 3 deletions lib/services/livesync/livesync-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ class LiveSyncService implements ILiveSyncService {
platform = this.$devicesService.getDeviceByIdentifier(this.$options.device).deviceInfo.platform;
liveSyncData.push(await this.prepareLiveSyncData(platform, projectData));
} else {
await this.$devicesService.initialize({ skipInferPlatform: true });

await this.$devicesService.stopDeviceDetectionInterval();
await this.$devicesService.initialize({ skipInferPlatform: true, skipDeviceDetectionInterval: true });

for (let installedPlatform of this.$platformService.getInstalledPlatforms(projectData)) {
if (this.$devicesService.getDevicesForPlatform(installedPlatform).length === 0) {
Expand Down
1 change: 0 additions & 1 deletion lib/services/local-build-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// import { exportedPromise } from "../common/decorators";
import { EventEmitter } from "events";
import { BUILD_OUTPUT_EVENT_NAME } from "../constants";

Expand Down
4 changes: 2 additions & 2 deletions lib/services/project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as constants from "../constants";
import * as path from "path";
import * as shelljs from "shelljs";
import { exportedPromise, exported } from "../common/decorators";
import { exported } from "../common/decorators";

export class ProjectService implements IProjectService {

Expand All @@ -16,7 +16,7 @@ export class ProjectService implements IProjectService {
private $projectTemplatesService: IProjectTemplatesService,
private $staticConfig: IStaticConfig) { }

@exportedPromise("projectService")
@exported("projectService")
public async createProject(projectOptions: IProjectSettings): Promise<void> {
let projectName = projectOptions.projectName,
selectedTemplate = projectOptions.template;
Expand Down